[PATCH][next] um: Malloc just enough space for fitting pid file
From: Paulo Miguel Almeida
Date: Fri Oct 25 2024 - 23:47:12 EST
umid is already generated during make_umid_init __initcall so there is
no need to allocate UMID_LEN bytes to accommodate the max possible name
for the umid segment of the filepath
This patch replaces UMID_LEN occurences in which it's redundant
Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@xxxxxxxxx>
---
arch/um/os-Linux/umid.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/um/os-Linux/umid.c b/arch/um/os-Linux/umid.c
index eb523ab1e218..513a2cce38db 100644
--- a/arch/um/os-Linux/umid.c
+++ b/arch/um/os-Linux/umid.c
@@ -212,7 +212,7 @@ static void __init create_pid_file(void)
char pid[sizeof("nnnnnnnnn")], *file;
int fd, n;
- n = strlen(uml_dir) + UMID_LEN + sizeof("/pid");
+ n = strlen(uml_dir) + strlen(umid) + sizeof("/pid");
file = malloc(n);
if (!file)
return;
@@ -394,7 +394,7 @@ static void remove_umid_dir(void)
{
char *dir, err;
- dir = malloc(strlen(uml_dir) + UMID_LEN + 1);
+ dir = malloc(strlen(uml_dir) + strlen(umid) + 1);
if (!dir)
return;
--
2.47.0