Re: [PATCH v4 1/4] dt-bindings: arm: qcom,coresight-static-replicator: Add property for source filtering

[Tao Zhang]

On 10/24/2024 6:36 PM, Suzuki K Poulose wrote:
> On 24/10/2024 10:14, Suzuki K Poulose wrote:
> > On 24/10/2024 07:53, Tao Zhang wrote:
> > > The is some "magic" hard coded filtering in the replicators,
> > > which only passes through trace from a particular "source". Add
> > > a new property "filter-src" to label a phandle to the coresight
> > > trace source device matching the hard coded filtering for the port.
> >
> > As mentioned in here in v3 review :
> >
> > https://lkml.org/lkml/2024/8/21/597
> >
> > Please do not use "src", expand it to "source"
>
> Just to confirm, this is only for the "bindings" string, not for the 
> variables used in the patches.

Yes, it is only used as the "bindings" string.


Best,

Tao

> Suzuki
>
>
> > Rest looks fine.
> >
> > Suzuki
> >
> > > Signed-off-by: Tao Zhang <quic_taozha@xxxxxxxxxxx>
> > > ---
> > >   .../arm/arm,coresight-static-replicator.yaml  | 19 
> > > ++++++++++++++++++-
> > >   1 file changed, 18 insertions(+), 1 deletion(-)
> > >
> > > diff --git 
> > > a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml 
> > > b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml 
> > >
> > > index 1892a091ac35..0d258c79eb94 100644
> > > --- 
> > > a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml
> > > +++ 
> > > b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml
> > > @@ -45,7 +45,22 @@ properties:
> > >       patternProperties:
> > >         '^port@[01]$':
> > >           description: Output connections to CoreSight Trace bus
> > > -        $ref: /schemas/graph.yaml#/properties/port
> > > +        $ref: /schemas/graph.yaml#/$defs/port-base
> > > +        unevaluatedProperties: false
> > > +
> > > +        properties:
> > > +          endpoint:
> > > +            $ref: /schemas/graph.yaml#/$defs/endpoint-base
> > > +            unevaluatedProperties: false
> > > +
> > > +            properties:
> > > +              filter-src:
> > > +                $ref: /schemas/types.yaml#/definitions/phandle
> > > +                description:
> > > +                  phandle to the coresight trace source device 
> > > matching the
> > > +                  hard coded filtering for this port
> > > +
> > > +              remote-endpoint: true
> > >   required:
> > >     - compatible
> > > @@ -72,6 +87,7 @@ examples:
> > >                   reg = <0>;
> > >                   replicator_out_port0: endpoint {
> > >                       remote-endpoint = <&etb_in_port>;
> > > +                    filter-src = <&tpdm_video>;
> > >                   };
> > >               };
> > > @@ -79,6 +95,7 @@ examples:
> > >                   reg = <1>;
> > >                   replicator_out_port1: endpoint {
> > >                       remote-endpoint = <&tpiu_in_port>;
> > > +                    filter-src = <&tpdm_mdss>;
> > >                   };
> > >               };
> > >           };