Re: [PATCH] crypto: cavium - Fix the if condition to exit loop after timeout

[Herbert Xu]

On Fri, Oct 18, 2024 at 10:23:10AM -0600, Everest K.C. wrote:
> The while loop breaks in the first run because of incorrect
> if condition. It also causes the statements after the if to
> appear dead.
> Fix this by changing the condition from if(timeout--) to
> if(!timeout--).
> 
> This bug was reported by Coverity Scan.
> Report:
> CID 1600859: (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: udelay(30UL);
> 
> Fixes: 9e2c7d99941d ("crypto: cavium - Add Support for Octeon-tx CPT Engine")
> Signed-off-by: Everest K.C. <everestkc@xxxxxxxxxxxxxxxx>
> ---
>  drivers/crypto/cavium/cpt/cptpf_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt