Re: [PATCH v2 1/2] dt-bindings: iio: light: veml6075: document rset-ohms
From: Krzysztof Kozlowski
Date: Sat Oct 26 2024 - 08:23:54 EST
On Thu, Oct 24, 2024 at 10:44:48PM +0200, Javier Carrasco wrote:
> The veml6070 provides a configurable integration time by means of an
> external resistor (Rset in the datasheet) with values between 75 and
> 1200 kohms.
>
> Document rset-ohms to select the integration time.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
> ---
> .../bindings/iio/light/vishay,veml6075.yaml | 27 ++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
> index 96c1317541fa..dfd64c411658 100644
> --- a/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
> @@ -22,6 +22,10 @@ properties:
> reg:
> maxItems: 1
>
> + rset-ohms:
> + description:
> + Resistor used to select the integration time.
Widest constraints should go here. If only one device supports them,
then it even simplifies the if:then.
> +
> vdd-supply: true
>
> required:
> @@ -29,6 +33,29 @@ required:
> - reg
> - vdd-supply
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + enum:
> + - vishay,veml6040
> + - vishay,veml6075
> + then:
> + properties:
> + rset-ohms: false
> +
> + - if:
> + properties:
> + compatible:
> + enum:
> + - vishay,veml6070
> + then:
> + properties:
> + rset-ohms:
> + default: 270000
> + minimum: 75000
> + maximum: 1200000
Move these three to top-level and then you can drop this if:.
Best regards,
Krzysztof