Re: [PATCH v2] ufs: core: Add WB buffer resize support
From: kernel test robot
Date: Sat Oct 26 2024 - 13:45:34 EST
Hi Huan,
kernel test robot noticed the following build errors:
[auto build test ERROR on jejb-scsi/for-next]
[also build test ERROR on mkp-scsi/for-next linus/master v6.12-rc4 next-20241025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Huan-Tang/ufs-core-Add-WB-buffer-resize-support/20241026-084545
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
patch link: https://lore.kernel.org/r/20241026004423.135-1-tanghuan%40vivo.com
patch subject: [PATCH v2] ufs: core: Add WB buffer resize support
config: i386-buildonly-randconfig-001-20241026 (https://download.01.org/0day-ci/archive/20241027/202410270108.zrM5GjRx-lkp@xxxxxxxxx/config)
compiler: clang version 19.1.2 (https://github.com/llvm/llvm-project 7ba7d8e2f7b6445b60679da826210cdde29eaf8b)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241027/202410270108.zrM5GjRx-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410270108.zrM5GjRx-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
In file included from drivers/ufs/core/ufs-sysfs.c:12:
In file included from drivers/ufs/core/ufshcd-priv.h:7:
In file included from include/ufs/ufshcd.h:16:
In file included from include/linux/blk-crypto-profile.h:9:
In file included from include/linux/bio.h:10:
In file included from include/linux/blk_types.h:10:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:8:
In file included from include/linux/cacheflush.h:5:
In file included from arch/x86/include/asm/cacheflush.h:5:
In file included from include/linux/mm.h:2213:
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> drivers/ufs/core/ufs-sysfs.c:441:2: error: use of undeclared identifier 'index'
441 | index = ufshcd_wb_get_query_index(hba);
| ^
1 warning and 1 error generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for GET_FREE_REGION
Depends on [n]: SPARSEMEM [=n]
Selected by [y]:
- RESOURCE_KUNIT_TEST [=y] && RUNTIME_TESTING_MENU [=y] && KUNIT [=y]
vim +/index +441 drivers/ufs/core/ufs-sysfs.c
413
414 static ssize_t wb_toggle_buf_resize_store(struct device *dev,
415 struct device_attribute *attr, const char *buf, size_t count)
416 {
417 struct ufs_hba *hba = dev_get_drvdata(dev);
418 unsigned int wb_buf_resize_op;
419 ssize_t res;
420
421 if (!ufshcd_is_wb_allowed(hba) || !hba->dev_info.wb_enabled ||
422 !hba->dev_info.b_presrv_uspc_en) {
423 dev_err(dev, "The WB buf resize is not allowed!\n");
424 return -EOPNOTSUPP;
425 }
426
427 if (kstrtouint(buf, 0, &wb_buf_resize_op))
428 return -EINVAL;
429
430 if (wb_buf_resize_op != 0x01 && wb_buf_resize_op != 0x02) {
431 dev_err(dev, "The operation %u is invalid!\n", wb_buf_resize_op);
432 return -EINVAL;
433 }
434
435 down(&hba->host_sem);
436 if (!ufshcd_is_user_access_allowed(hba)) {
437 res = -EBUSY;
438 goto out;
439 }
440
> 441 index = ufshcd_wb_get_query_index(hba);
442 ufshcd_rpm_get_sync(hba);
443 res = ufshcd_wb_toggle_buf_resize(hba, wb_buf_resize_op);
444 ufshcd_rpm_put_sync(hba);
445
446 out:
447 up(&hba->host_sem);
448 return res < 0 ? res : count;
449 }
450
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki