Re: [PATCH 1/2] time: revert cleanup on msecs_to_jiffies() documentation

[Randy Dunlap]

On 10/25/24 4:01 AM, Miguel Ojeda wrote:
> The documentation's intention is to compare `msecs_to_jiffies` (first
> sentence) with `__msecs_to_jiffies` (second sentence), which is what the
> original documentation did. One of the cleanups in commit f3cb80804b82
> ("time: Fix various kernel-doc problems") may have thought the paragraph
> was talking about the latter since that is what it is being documented.
> 
> Thus revert that part of the change.
> 
> Fixes: f3cb80804b82 ("time: Fix various kernel-doc problems")
> Signed-off-by: Miguel Ojeda <ojeda@xxxxxxxxxx>

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

> ---
>  kernel/time/time.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/time/time.c b/kernel/time/time.c
> index 642647f5046b..e1879ca32103 100644
> --- a/kernel/time/time.c
> +++ b/kernel/time/time.c
> @@ -558,7 +558,7 @@ EXPORT_SYMBOL(ns_to_timespec64);
>   *   handling any 32-bit overflows.
>   *   for the details see __msecs_to_jiffies()
>   *
> - * __msecs_to_jiffies() checks for the passed in value being a constant
> + * msecs_to_jiffies() checks for the passed in value being a constant
>   * via __builtin_constant_p() allowing gcc to eliminate most of the
>   * code, __msecs_to_jiffies() is called if the value passed does not
>   * allow constant folding and the actual conversion must be done at
> 
> base-commit: 42f7652d3eb527d03665b09edac47f85fb600924

-- 
~Randy