Re: [PATCH v3 1/3] dt-bindings: leds: Add LED1202 LED Controller

From: Krzysztof Kozlowski
Date: Sun Oct 27 2024 - 16:33:49 EST


On Sat, Oct 26, 2024 at 04:46:03PM +0200, Vicentiu Galanopulo wrote:
> The LED1202 is a 12-channel low quiescent current LED driver with:
> * Supply range from 2.6 V to 5 V
> * 20 mA current capability per channel
> * 1.8 V compatible I2C control interface
> * 8-bit analog dimming individual control
> * 12-bit local PWM resolution
> * 8 programmable patterns
>
> If the led node is present in the controller then the channel is
> set to active.
>
> Signed-off-by: Vicentiu Galanopulo <vicentiu.galanopulo@xxxxxxxxxxxxxxxxx>
> ---
>
> Changes in v3:
> - remove active property
> Changes in v2:
> - renamed label to remove color from it
> - add color property for each node
> - add function and function-enumerator property for each node

Where is the rest of the patches? I commented previously that you send
them in some odd way messing with reviewers MUAs and lists.

It seems nothing improved. Follow submitting-patches and use git
format-patch or b4, where both handle it correctly.


>
> .../devicetree/bindings/leds/st,led1202.yml | 103 ++++++++++++++++++
> 1 file changed, 103 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/st,led1202.yml

OK, so you just ignored entire previous feedback?

NAK.

Best regards,
Krzysztof