fs/bcachefs/reflink.c:37:5-8: Unneeded variable: "ret". Return "0" on line 44

From: kernel test robot
Date: Sun Oct 27 2024 - 22:10:10 EST


tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 81983758430957d9a5cb3333fe324fd70cf63e7e
commit: 074cbcdaeee433a02d6d0565b936bee0915cc5da bcachefs: fsck_err()s don't need to manually check c->sb.version anymore
date: 10 months ago
config: m68k-randconfig-r051-20241027 (https://download.01.org/0day-ci/archive/20241028/202410281008.mjKBN0fU-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 14.1.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410281008.mjKBN0fU-lkp@xxxxxxxxx/

cocci warnings: (new ones prefixed by >>)
>> fs/bcachefs/reflink.c:37:5-8: Unneeded variable: "ret". Return "0" on line 44

vim +37 fs/bcachefs/reflink.c

31
32 int bch2_reflink_p_invalid(struct bch_fs *c, struct bkey_s_c k,
33 enum bkey_invalid_flags flags,
34 struct printbuf *err)
35 {
36 struct bkey_s_c_reflink_p p = bkey_s_c_to_reflink_p(k);
> 37 int ret = 0;
38
39 bkey_fsck_err_on(le64_to_cpu(p.v->idx) < le32_to_cpu(p.v->front_pad),
40 c, err, reflink_p_front_pad_bad,
41 "idx < front_pad (%llu < %u)",
42 le64_to_cpu(p.v->idx), le32_to_cpu(p.v->front_pad));
43 fsck_err:
> 44 return ret;
45 }
46

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki