Re: [PATCH for-next 1/3] selftests/watchdog: add count parameter for watchdog-test
From: Shuah Khan
Date: Sun Oct 27 2024 - 23:29:30 EST
On 10/27/24 18:50, Zhijian Li (Fujitsu) wrote:
On 27/10/2024 08:28, Shuah Khan wrote:
On 10/24/24 19:39, Li Zhijian wrote:
Currently, watchdog-test keep running until it gets a SIGINT. However,
when watchdog-test is executed from the kselftests framework, where it
launches test via timeout which will send SIGTERM in time up. This could
lead to
1. watchdog haven't stop, a watchdog reset is triggered to reboot the OS
in silent.
2. kselftests gets an timeout exit code, and judge watchdog-test as
'not ok'
This test isn't really supposed to be run from kselftest framework.
This is the reason why it isn't included in the default run.
May I know what's the default run, is it different from `make run_tests` ?
No it isn't. "make kselftest" runs only the targets mentioned in the
selftests Makefile. That is considered the kselftest default run.
There is a reason why watchdog isn't included in the default run.
It isn't intended to be run by users by default as this is test is
just for testing watchdog api
This patch is prepare to fix above 2 issues
This series needs a separate cover letter explaining how this problem is
being fixed.
Cover letter is in this patch, see below:
In addition, we can get the 'How' by reading the simple change in each change.
That isn't enough to understand why this change is needed.
Send patch series with a cover letter explaining what you are
doing.
Signed-off-by: Li Zhijian <lizhijian@xxxxxxxxxxx>
---
Hey,
Cover letter is here.
It's notice that a OS reboot was triggerred after ran the watchdog-test
in kselftests framwork 'make run_tests', that's because watchdog-test
didn't stop feeding the watchdog after enable it.
In addition, current watchdog-test didn't adapt to the kselftests
framework which launchs the test with /usr/bin/timeout and no timeout
is expected.
---
thanks,
-- Shuah