Re: [PATCH v1 06/10] media: platform: mediatek: add isp_7x utility
From: CK Hu (胡俊光)
Date: Sun Oct 27 2024 - 23:46:48 EST
Hi, Shu-hsiang:
On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> Introduces utility files for the MediaTek ISP7.x camsys driver. These
> utilities provide essential platform definitions, debugging tools, and
> management functions to support ISP operations and SCP communication.
> Key functionalities include:
> 1.Hardware pipeline and register definitions for managing image
> processing modules.
> 2.DMA debugging utilities and buffer management functions.
> 3.Definitions of supported image formats for proper data handling.
> 4.IPI and SCP communication structures for module state management and
> configuring ISP.
> 5.Metadata parameters for configuring image processing.
>
> Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@xxxxxxxxxxxx>
> ---
[snip]
> +/*
> + * struct mtkcam_ipi_hw_buffer - DMA buffer for CAM DMA device.
> + *
> + * @iova: DMA address for CAM DMA device. isp7_1: u64.
> + * @size: buffer size.
> + */
> +struct mtkcam_ipi_hw_buffer {
> + u64 iova;
> + u32 size;
> +} __packed;
> +
mtkcam_ipi_hw_buffer is useless, so drop it.
Regards,
CK