Re: [PATCH v9] perf/marvell: Marvell PEM performance monitor support
From: Gowthami Thiagarajan
Date: Mon Oct 28 2024 - 01:20:47 EST
Hi Will,
From: Will Deacon <will@xxxxxxxxxx>
Sent: Thursday, October 24, 2024 6:02 PM
To: Gowthami Thiagarajan <gthiagarajan@xxxxxxxxxxx>
Cc: mark.rutland@xxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; George Cherian <gcherian@xxxxxxxxxxx>; Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>; Linu Cherian <lcherian@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [PATCH v9] perf/marvell: Marvell PEM performance monitor support
On Wed, Oct 16, 2024 at 06:44:57PM +0530, Gowthami Thiagarajan wrote:
> PCI Express Interface PMU includes various performance counters
> to monitor the data that is transmitted over the PCIe link. The
> counters track various inbound and outbound transactions which
> includes separate counters for posted/non-posted/completion TLPs.
> Also, inbound and outbound memory read requests along with their
> latencies can also be monitored. Address Translation Services(ATS)events
> such as ATS Translation, ATS Page Request, ATS Invalidation along with
> their corresponding latencies are also supported.
>
> The performance counters are 64 bits wide.
>
> For instance,
> perf stat -e ib_tlp_pr <workload>
> tracks the inbound posted TLPs for the workload.
>
> Signed-off-by: Gowthami Thiagarajan <mailto:gthiagarajan@xxxxxxxxxxx>
> Signed-off-by: Linu Cherian <mailto:lcherian@xxxxxxxxxxx>
I think this Signed-off-by: line from Linu is new in v9. What happened?
I notice that Linu is listed as the driver author:
> +MODULE_DESCRIPTION("Marvell PEM Perf driver");
> +MODULE_AUTHOR("Linu Cherian <mailto:lcherian@xxxxxxxxxxx>");
but the patch author is you, so git blame will be inconsistent.
Please can you make sure that MODULE_AUTHOR and the patch author are
consistent, and then use Co-developed-by as well as the additional SoB
for the second author?
Had this discussed internally. I will change the MODULE_AUTHOR to myself and add the
tags as suggested.
-Gowthami