Re: [PATCH 18/21] sched/idle: Switch to use hrtimer_setup_on_stack()

[Peter Zijlstra]

On Mon, Oct 28, 2024 at 08:29:37AM +0100, Nam Cao wrote:
> There is a newly introduced function hrtimer_setup_on_stack(), which will
> replace hrtimer_init_on_stack(). In addition to what
> hrtimer_init_on_stack() does, this new function also sanity-checks and
> initializes the callback function pointer.
> 
> Switch to use the new function.
> 
> Patch was created by using Coccinelle.
> 
> Signed-off-by: Nam Cao <namcao@xxxxxxxxxxxxx>
> ---
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> ---
>  kernel/sched/idle.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c
> index d2f096bb274c..631e42802925 100644
> --- a/kernel/sched/idle.c
> +++ b/kernel/sched/idle.c
> @@ -399,8 +399,8 @@ void play_idle_precise(u64 duration_ns, u64 latency_ns)
>  	cpuidle_use_deepest_state(latency_ns);
>  
>  	it.done = 0;
> -	hrtimer_init_on_stack(&it.timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_HARD);
> -	it.timer.function = idle_inject_timer_fn;
> +	hrtimer_setup_on_stack(&it.timer, idle_inject_timer_fn, CLOCK_MONOTONIC,
> +			       HRTIMER_MODE_REL_HARD);

WTF is hrtimer_setup_on_stack() ?

Do NOT send partial series. How the hell am I supposed to review things
if I don't even get to see the implementation of things,eh?