Re: [PATCH] media: raspberrypi: Remove redundant "no IRQ" message

From: Tomi Valkeinen
Date: Mon Oct 28 2024 - 05:28:30 EST


Hi,

On 18/10/2024 17:24, Ricardo Ribalda wrote:
platform_get_irq() already provides a error message.

This fixes the following cocci error:
drivers/media/platform/raspberrypi/rp1-cfe/cfe.c:2326:2-9: line 2326 is redundant because platform_get_irq() already prints an error

Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
---
drivers/media/platform/raspberrypi/rp1-cfe/cfe.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
index 045910de6c57..4e99cccd9a20 100644
--- a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
+++ b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
@@ -2323,7 +2323,6 @@ static int cfe_probe(struct platform_device *pdev)
ret = platform_get_irq(pdev, 0);
if (ret <= 0) {
- dev_err(&pdev->dev, "No IRQ resource\n");
ret = -EINVAL;
goto err_cfe_put;
}

---
base-commit: 698b6e3163bafd61e1b7d13572e2c42974ac85ec
change-id: 20241018-rpi-irq-cocci-878e4a82ea2c

Best regards,

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>

Tomi