Re: [PATCH] watchdog: Add HAS_IOPORT dependency for SBC8360 and SBC7240

[Arnd Bergmann]

On Mon, Oct 14, 2024, at 11:25, Niklas Schnelle wrote:
> Both drivers use I/O port accesses without declaring a dependency on
> CONFIG_HAS_IOPORT. For sbc8360_wdt this causes a compile error on UML
> once inb()/outb() helpers become conditional.
>
> For sbc7240_wdt this causes no such errors with UML because this driver
> depends on both x86_32 and !UML. Nevertheless add HAS_IOPORT as
> a dependency for both drivers to be explicit and drop the !UML
> dependency for sbc7240_wdt as it is now redundant since UML implies no
> HAS_IOPORT.
>
> Fixes: 52df67b6b313 ("watchdog: add HAS_IOPORT dependencies")
> Signed-off-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>

I applied this to the asm-generic tree as well now, seeing that
it was not part of the HAS_IOPORT series but is required for UML.

      Arnd