Re: [PATCH net] net: enetc: set MAC address to the VF net_device

From: Vladimir Oltean
Date: Mon Oct 28 2024 - 07:51:30 EST


On Mon, Oct 28, 2024 at 04:52:42PM +0800, Wei Fang wrote:
> The MAC address of VF can be configured through the mailbox mechanism of
> ENETC, but the previous implementation forgot to set the MAC address in
> net_device, resulting in the SMAC of the sent frames still being the old
> MAC address. Since the MAC address in the hardware has been changed, Rx
> cannot receive frames with the DMAC address as the new MAC address. The
> most obvious phenomenon is that after changing the MAC address, we can
> see that the MAC address of eno0vf0 has not changed through the "ifconfig
> eno0vf0" commandand the IP address cannot be obtained .
>
> root@ls1028ardb:~# ifconfig eno0vf0 down
> root@ls1028ardb:~# ifconfig eno0vf0 hw ether 00:04:9f:3a:4d:56 up
> root@ls1028ardb:~# ifconfig eno0vf0
> eno0vf0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1500
> ether 66:36:2c:3b:87:76 txqueuelen 1000 (Ethernet)
> RX packets 794 bytes 69239 (69.2 KB)
> RX errors 0 dropped 0 overruns 0 frame 0
> TX packets 11 bytes 2226 (2.2 KB)
> TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0
>
> Fixes: beb74ac878c8 ("enetc: Add vf to pf messaging support")
> Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>