Re: [PATCH v1] arm64: dts: qcom: qcs615: Add QUPv3 configuration

[Dmitry Baryshkov]

On Mon, Oct 28, 2024 at 04:49:43PM +0530, Viken Dadhaniya wrote:
> 
> 
> On 10/26/2024 1:10 AM, Konrad Dybcio wrote:
> > On 11.10.2024 12:33 PM, Viken Dadhaniya wrote:
> > > Add DT support for QUPv3 Serial Engines.
> > > 
> > > Co-developed-by: Mukesh Kumar Savaliya <quic_msavaliy@xxxxxxxxxxx>
> > > Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@xxxxxxxxxxx>
> > > Signed-off-by: Viken Dadhaniya <quic_vdadhani@xxxxxxxxxxx>
> > > ---
> > 
> > [...]
> > 
> > > @@ -392,6 +427,24 @@
> > >   			#size-cells = <1>;
> > >   		};
> > > +		gpi_dma0: qcom,gpi-dma@800000  {
> > > +			compatible = "qcom,sdm845-gpi-dma";
> > 
> > You must define a new compatible for qcs615, sdm845 is used as a fallback
> > (so that we don't have to add new driver entries). You will however need
> > to submit a separate dt-bindings change.
> 
> We have added sdm845 in compatible due to below comment in driver file
> 
> File: https://github.com/torvalds/linux/blob/81983758430957d9a5cb3333fe324fd70cf63e7e/drivers/dma/qcom/gpi.c#L2284
> 
>   /*
>    * Do not grow the list for compatible devices. Instead use
>    * qcom,sdm845-gpi-dma (for ee_offset = 0x0) or qcom,sm6350-gpi-dma
>    * (for ee_offset = 0x10000).
>    */
> 
> Do we still require new compatible for qcs615 ?

You are not living in the void space. `git grep qcom,sdm845-gpi-dma`
immediately shows what is being expected. Please don't ignore existing
work.

> 
> > 

-- 
With best wishes
Dmitry