Re: [PATCH 2/3] pinctrl: sophgo: add support for SG2042 SoC

From: Linus Walleij
Date: Mon Oct 28 2024 - 09:03:12 EST


On Thu, Oct 24, 2024 at 8:44 AM Inochi Amaoto <inochiama@xxxxxxxxx> wrote:

> Add base driver for SG2042 SoC and pin definition.
>
> Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx>

This driver is clearly duplicating a ton of code from pinctrl-cv18xx.c.

We have no interest in having to fix bugs in two places.

Please factor out the common code and use the same code
in the new driver if you can't make the new driver a simple
subdriver och pinctrl-cv18xx.c.

Yours,
Linus Walleij