Re: [PATCH] nvme-pci: Force NVME_QUIRK_SIMPLE_SUSPEND on Qualcomm hosts

From: Konrad Dybcio
Date: Mon Oct 28 2024 - 09:15:37 EST


On 28.10.2024 10:19 AM, Christoph Hellwig wrote:
> On Fri, Oct 25, 2024 at 05:30:05PM +0200, Konrad Dybcio wrote:
>> (Un?)fortunately, said platforms use FDT, so we can't fix that in ACPI.
>
> Then generalize the acpi helper to a generic one checking ACPI and
> DT and specify a proper DT binding.
>
> If th requirement to put all devices into D3 is a plaform propery
> a specific driver is always the wrong place for it.
>
>> b) Adding such a property to the PCIe host node sounds a bit
>> saner, but the NVMe code isn't aware of the RC. We could add
>> something like:
>
> Again, this all belongs into core code. The nvme driver is just
> a consumer of this information, just like for example the AHCI
> driver.

Alright, I'll try to pursue that angle instead,

Konrad