Re: [PATCH v6 05/10] x86/virt/tdx: Add missing header file inclusion to local tdx.h

From: Nikolay Borisov
Date: Mon Oct 28 2024 - 09:35:37 EST




On 28.10.24 г. 14:41 ч., Kai Huang wrote:
Compiler attributes __packed and __aligned, and DECLARE_FLEX_ARRAY() are
currently used in arch/x86/virt/vmx/tdx/tdx.h, but the relevant headers
are not included explicitly.

There's no build issue in the current code since this "tdx.h" is only
included by arch/x86/virt/vmx/tdx/tdx.c and it includes bunch of other
<linux/xxx.h> before including "tdx.h". But for the better explicitly
include the relevant headers to "tdx.h". Also include <linux/types.h>
for basic variable types like u16.

Signed-off-by: Kai Huang <kai.huang@xxxxxxxxx>

Reviewed-by: Nikolay Borisov <nik.borisov@xxxxxxxx>