Re: [PATCH] ext4: Add a sanity check for next dentry when insert
From: kernel test robot
Date: Mon Oct 28 2024 - 10:16:38 EST
Hi Edward,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tytso-ext4/dev]
[also build test WARNING on linus/master v6.12-rc5 next-20241028]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Edward-Adam-Davis/ext4-Add-a-sanity-check-for-next-dentry-when-insert/20241027-191200
base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
patch link: https://lore.kernel.org/r/tencent_E4CFC65D09852ECE2EF28C83A7C3C6E41206%40qq.com
patch subject: [PATCH] ext4: Add a sanity check for next dentry when insert
config: x86_64-randconfig-121-20241028 (https://download.01.org/0day-ci/archive/20241028/202410282131.FBDMC1Gq-lkp@xxxxxxxxx/config)
compiler: clang version 19.1.2 (https://github.com/llvm/llvm-project 7ba7d8e2f7b6445b60679da826210cdde29eaf8b)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241028/202410282131.FBDMC1Gq-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410282131.FBDMC1Gq-lkp@xxxxxxxxx/
sparse warnings: (new ones prefixed by >>)
>> fs/ext4/namei.c:2087:5: sparse: sparse: symbol 'ext4_check_next_dentry' was not declared. Should it be static?
fs/ext4/namei.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/xarray.h, ...):
include/linux/page-flags.h:237:46: sparse: sparse: self-comparison always evaluates to false
include/linux/page-flags.h:237:46: sparse: sparse: self-comparison always evaluates to false
fs/ext4/namei.c: note: in included file:
fs/ext4/ext4.h:2429:9: sparse: sparse: self-comparison always evaluates to false
vim +/ext4_check_next_dentry +2087 fs/ext4/namei.c
2086
> 2087 int ext4_check_next_dentry(struct inode *dir,
2088 struct inode *inode,
2089 struct ext4_dir_entry_2 *de,
2090 int buf_size,
2091 struct ext4_filename *fname)
2092 {
2093 int nlen, rlen;
2094
2095 nlen = ext4_dir_rec_len(de->name_len, dir);
2096 rlen = ext4_rec_len_from_disk(de->rec_len, buf_size);
2097 if (de->inode) {
2098 struct ext4_dir_entry_2 *nde =
2099 (struct ext4_dir_entry_2 *)((char *)de + nlen);
2100 nde->rec_len = ext4_rec_len_to_disk(rlen - nlen, buf_size);
2101 de->rec_len = ext4_rec_len_to_disk(nlen, buf_size);
2102 de = nde;
2103 rlen = ext4_rec_len_from_disk(de->rec_len, buf_size);
2104 return fname_len(fname) > rlen - EXT4_BASE_DIR_LEN;
2105 }
2106
2107 return 0;
2108 }
2109
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki