Re: [PATCH 01/18] PCI/P2PDMA: refactor the p2pdma mapping helpers

From: Logan Gunthorpe
Date: Mon Oct 28 2024 - 14:11:52 EST




On 2024-10-27 08:21, Leon Romanovsky wrote:
> From: Christoph Hellwig <hch@xxxxxx>
>
> The current scheme with a single helper to determine the P2P status
> and map a scatterlist segment force users to always use the map_sg
> helper to DMA map, which we're trying to get away from because they
> are very cache inefficient.
>
> Refactor the code so that there is a single helper that checks the P2P
> state for a page, including the result that it is not a P2P page to
> simplify the callers, and a second one to perform the address translation
> for a bus mapped P2P transfer that does not depend on the scatterlist
> structure.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>

Looks good to me. Thanks!

Reviewed-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>