Re: [PATCH] kdb: Fix breakpoint enable to be silent if already enabled

[Doug Anderson]

Hi,

On Sun, Oct 27, 2024 at 1:47 PM Nir Lichtman <nir@xxxxxxxxxxxx> wrote:
>
> Fix the breakpoint enable command (be) to a logic that is inline with the
> breakpoint disable command (bd) in which if the breakpoint is already in
> an enabled state, do not print the message of enabled again to the user.
>
> Also a small nit fix of the new line in a separate print.
>
> Signed-off-by: Nir Lichtman <nir@xxxxxxxxxxxx>
>
> ---
>  kernel/debug/kdb/kdb_bp.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

I don't ever use these commands (if I'm setting breakpoints them I'm
using kgdb, not kdb), but this seems OK to me in general. I'm a little
curious why you don't also make the "breakpoint clear" command
consistent.

-Doug