Re: [PATCH v4 1/4] iio: imu: bmi270: Add triggered buffer for Bosch BMI270 IMU

[Jonathan Cameron]

On Mon, 28 Oct 2024 11:25:06 +0200
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> On Sun, Oct 27, 2024 at 10:20:22AM -0700, Justin Weiss wrote:
> > Set up a triggered buffer for the accel and angl_vel values.  
> 
> ...
> 
> >  	.channel2 = IIO_MOD_##_axis,				\
> >  	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),		\
> > +	.scan_index = BMI270_SCAN_ACCEL_##_axis,		\
> > +	.scan_type = {						\
> > +		.sign = 's',					\
> > +		.realbits = 16,					\
> > +		.storagebits = 16,				\
> > +		.endianness = IIO_LE				\  
> 
> Leave trailing comma here.
> 
> > +	},	                                                \  
> 
> ...
> 
> >  	.channel2 = IIO_MOD_##_axis,				\
> >  	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),		\
> > +	.scan_index = BMI270_SCAN_GYRO_##_axis,			\
> > +	.scan_type = {						\
> > +		.sign = 's',					\
> > +		.realbits = 16,					\
> > +		.storagebits = 16,				\
> > +		.endianness = IIO_LE				\  
> 
> Ditto.
> 
> > +	},	                                                \  
> 
Agreed. Tweaked whilst applying

Jonathan