Re: [PATCH v3 3/6] iio: light: stk3310: Implement vdd and leda supplies

[Dragan Simic]

Hello Aren,

On 2024-10-28 15:38, Andy Shevchenko wrote:
> On Mon, Oct 28, 2024 at 10:19:57AM -0400, Aren Moynihan wrote:
> > The vdd and leda supplies must be powered on for the chip to function
> > and can be powered off during system suspend.
> >
> > Co-developed-by: Ondrej Jirman <megi@xxxxxx>
>
> Missing SoB. Please, read Submitting Patches documentation for 
> understanding
> what has to be done here.
>
> > Signed-off-by: Aren Moynihan <aren@xxxxxxxxxxxxxxxxx>
>
> ...
>
> > Notes:
> >     I'm not sure what the proper way to handle attribution for this 
> > patch
> >     is. It was origionally based on a patch by Ondrej Jirman[1], but I 
> > have
> >     rewritten a large portion if it. I have included a Co-developed-by 
> > tag
> >     to indicate this, but haven't sent him this patch, so I'm not sure 
> > what
> >     to do about a Signed-off-by.
>
> Ah, seems you already aware of this issue. So, either drop 
> Co-developed-by
> (and if you wish you may give a credit in a free form inside commit 
> message)
> or make sure you get his SoB tag.

Perhaps the best and also easiest solution would be to provide an
Originally-by tag for Ondrej, because that's what it is.  The patch
was written originally by Ondrej, but you've changed many parts of
the patch while upstreaming it.