Re: [PATCH hotfix 6.12 v2 4/8] mm: resolve faulty mmap_region() error path behaviour
From: Vlastimil Babka
Date: Mon Oct 28 2024 - 17:29:15 EST
On 10/28/24 22:19, Linus Torvalds wrote:
> On Mon, 28 Oct 2024 at 11:00, Vlastimil Babka <vbabka@xxxxxxx> wrote:
>>
>> VM_MTE_ALLOWED is also set by arm64's arch_calc_vm_flag_bits():
>>
>> if (system_supports_mte() && (flags & MAP_ANONYMOUS))
>> return VM_MTE_ALLOWED;
>
> Yeah, but that should just move into arch_validate_flags() too.
> There's no reason why that's done in a separate place.
>
> Linus
Right, and VM_DATA_DEFAULT_FLAGS is only used in do_brk_flags() which is
also an anonymous VMA, and it doesn't perform arch_validate_flags() anyway.