Re: [PATCH v6 10/10] x86/virt/tdx: Print TDX module version
From: Dan Williams
Date: Mon Oct 28 2024 - 18:36:32 EST
Kai Huang wrote:
> Currently the kernel doesn't print any TDX module version information.
> In practice such information is useful, especially to the developers.
>
> For instance:
>
> 1) When something goes wrong around using TDX, the module version is
> normally the first information the users want to know [1].
>
> 2) The users want to quickly know module version to see whether the
> loaded module is the expected one.
>
> Dump TDX module version. The actual dmesg will look like:
>
> virt/tdx: module version: 1.5.00.00.0481 (build_date 20230323).
>
> And dump right after reading global metadata, so that this information is
> printed no matter whether module initialization fails or not.
>
> Link: https://lore.kernel.org/lkml/4b3adb59-50ea-419e-ad02-e19e8ca20dee@xxxxxxxxx/ [1]
> Signed-off-by: Kai Huang <kai.huang@xxxxxxxxx>
LGTM, would be nice if the build hash was also included to precisely
identify the image, but will need to ask for that metadata to be added.
Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>