Re: [PATCHv2 2/2] zram: clear IDLE flag in mark_idle()

From: Sergey Senozhatsky
Date: Mon Oct 28 2024 - 20:10:09 EST


On (24/10/28 13:57), Brian Geffon wrote:
> On Tue, Oct 29, 2024 at 12:36:15AM +0900, Sergey Senozhatsky wrote:
> > If entry does not fulfill current mark_idle() parameters, e.g.
> > cutoff time, then we should clear its ZRAM_IDLE from previous
> > mark_idle() invocations.
> >
> > Consider the following case:
> > - mark_idle() cutoff time 8h
> > - mark_idle() cutoff time 4h
> > - writeback() idle - will writeback entries with cutoff time 8h,
> > while it should only pick entries with cutoff time 4h
> >
> > The bug was reported by Shin Kawamura.
> Reported-by: Shin Kawamura <kawasin@xxxxxxxxxx>

This is how it was in v1, but that triggered a warn

WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#16:
Reported-by: Shin Kawamura <kawasin@xxxxxxxxxx>
Signed-off-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>

so I switched to less "formal" reported-by tag in v2.