Re: [PATCH 0/2] platform/x86: asus-wmi: Fix thermal profile handling

[Bowman, Casey G]

Ran a quick test with the two patches on top of drm-tip while monitoring the sensor's temperature as well as thermald logs.

While running "stress -c 8" for around two minutes for each mode, I can see the SEN1 temperature plateau at the expected areas for the various power modes:

- Power Saver
    - Max temp observed: 51 C
    - Trip temperature: 51 C

- Balanced
    - Max temp observed: 56 C
    - Trip temperature: 56 C

- Performance
    - Max temp observed: 61 C
    - Trip temperature: 61 C

Cycling from higher power modes to lower power modes works as expected, with the temperatures falling back to the peak values listed for the given mode.

>From my observations, these patches are working as intended.

Regards,
Casey

________________________________________
From: srinivas pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
Sent: Friday, October 25, 2024 9:09 PM
To: Armin Wolf <W_Armin@xxxxxx>; corentin.chary@xxxxxxxxx <corentin.chary@xxxxxxxxx>; luke@xxxxxxxxxx <luke@xxxxxxxxxx>; Ghanmi, Mohamed <mohamed.ghanmi@xxxxxxxxx>; Bowman, Casey G <casey.g.bowman@xxxxxxxxx>
Cc: hdegoede@xxxxxxxxxx <hdegoede@xxxxxxxxxx>; ilpo.jarvinen@xxxxxxxxxxxxxxx <ilpo.jarvinen@xxxxxxxxxxxxxxx>; Michael@xxxxxxxxxxxx <Michael@xxxxxxxxxxxx>; Bowman, Casey G <casey.g.bowman@xxxxxxxxx>; platform-driver-x86@xxxxxxxxxxxxxxx <platform-driver-x86@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH 0/2] platform/x86: asus-wmi: Fix thermal profile handling
 
+Casey

On Fri, 2024-10-25 at 21:15 +0200, Armin Wolf wrote:
> When support for Vivobook fan profiles was added, two mistakes where
> made:
>
> 1. throttle_thermal_policy_set_default() was not called anymore
> during
> probe.
>
> 2. The new thermal profiles where used inconsistently.
>
> This patch series aims to fix both issues. Compile-tested only.
>
Thanks for these patches. The first one I already tested with the same
change, for the second one added Casey to check if he can give a quick
test for both on the new Asus Lunar Lake laptop.

Thanks,
Srinivas




> Armin Wolf (2):
>   platform/x86: asus-wmi: Fix thermal profile initialization
>   platform/x86: asus-wmi: Fix inconsistent use of thermal policies
>
>  drivers/platform/x86/asus-wmi.c | 74 ++++++++++++++-----------------
> --
>  1 file changed, 31 insertions(+), 43 deletions(-)
>
> --
> 2.39.5
>