[PATCH] usb: typec: qcom-pmic: fix uninitialized value hdr_len and txbuf_len
From: Rex Nie
Date: Mon Oct 28 2024 - 22:18:56 EST
If the read of USB_PDPHY_RX_ACKNOWLEDGE_REG failed, then hdr_len and
txbuf_len are uninitialized. It makes no sense to print message header
and payload. It is also not safe to print uninitialized length of ram.
Signed-off-by: Rex Nie <rex.nie@xxxxxxxxxxxxxxx>
---
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
index 5b7f52b74a40..53c2180a773a 100644
--- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
+++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
@@ -221,7 +221,7 @@ qcom_pmic_typec_pdphy_pd_transmit_payload(struct pmic_typec_pdphy *pmic_typec_pd
unsigned int negotiated_rev)
{
struct device *dev = pmic_typec_pdphy->dev;
- unsigned int val, hdr_len, txbuf_len, txsize_len;
+ unsigned int val, hdr_len = 0, txbuf_len = 0, txsize_len;
unsigned long flags;
int ret;
--
2.17.1