Re: [PATCH for-next 1/3] selftests/watchdog: add count parameter for watchdog-test

[Shuah Khan]

On 10/28/24 00:44, Shuah Khan wrote:
> On 10/28/24 00:32, Zhijian Li (Fujitsu) wrote:
> > On 28/10/2024 14:25, Shuah Khan wrote:
> > > On 10/28/24 00:06, Zhijian Li (Fujitsu) wrote:
> > > > linux/tools/testing/selftests/watchdog# make run_tests
> > > > TAP version 13
> > > > 1..1
> > > > # timeout set to 45
> > > > # selftests: watchdog: watchdog-test
> > > > # Watchdog Ticking Away!
> > > > # .............................................#
> > > > not ok 1 selftests: watchdog: watchdog-test # TIMEOUT 45 seconds
> > > >
> > > >
> > > > And i got warning in dmesg
> > > >
> > > > [ 1953.229511] watchdog: watchdog0: watchdog did not stop!
> > >
> > > Run "make run_tests" under strace and send me the output.
> >
> >
> > Could you share the exact command, how to 'Run "make run_tests" under strace'
>
> strace make run_tests > strace.out 2>&1
>
> Send me strace.out

Thank you for the strace output. kselftest uses a timeout to terminate
hung tests - that timeout is 45 seconds. When you run "make run_tests"
under watchdog directory, you are running into this.

Yes your fix to add SIGTERM handling makes sense. Please also handle
other signals - SIGKILL, SIGQUIT.

Thanks for the find.

thanks,
-- Shuah