Re: [PATCH v3] xhci: Fix Link TRB DMA in command ring stopped completion event
From: Greg Kroah-Hartman
Date: Mon Oct 28 2024 - 23:22:47 EST
On Thu, Oct 24, 2024 at 05:06:44PM +0300, Mathias Nyman wrote:
> On 22.10.2024 18.56, Faisal Hassan wrote:
> > During the aborting of a command, the software receives a command
> > completion event for the command ring stopped, with the TRB pointing
> > to the next TRB after the aborted command.
> >
> > If the command we abort is located just before the Link TRB in the
> > command ring, then during the 'command ring stopped' completion event,
> > the xHC gives the Link TRB in the event's cmd DMA, which causes a
> > mismatch in handling command completion event.
> >
> > To address this situation, move the 'command ring stopped' completion
> > event check slightly earlier, since the specific command it stopped
> > on isn't of significant concern.
> >
> > Fixes: 7f84eef0dafb ("USB: xhci: No-op command queueing and irq handler.")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Faisal Hassan <quic_faisalh@xxxxxxxxxxx>
>
> Acked-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
>
> Greg, would you like to take this directly to usb-linus (6.12)?
> If not I'll send it as part of series to usb-next later
Sure, I'll take it now, thanks.
greg k-h