Re: [PATCH v12 4/8] mtd: nand: Add qpic_common API file

[Md Sadre Alam]

On 10/25/2024 11:57 PM, Jeff Johnson wrote:
> On 10/21/2024 9:39 PM, Md Sadre Alam wrote:
> > On 10/21/2024 11:49 PM, Jeff Johnson wrote:
> > > On 10/21/24 04:56, Md Sadre Alam wrote:
> > > ...
> > > > diff --git a/drivers/mtd/nand/qpic_common.c b/drivers/mtd/nand/qpic_common.c
> > > > new file mode 100644
> > > > index 000000000000..570ab59ca12b
> > > > --- /dev/null
> > > > +++ b/drivers/mtd/nand/qpic_common.c
> > > > @@ -0,0 +1,757 @@
> > > > +// SPDX-License-Identifier: GPL-2.0-only
> > > > +/*
> > > > + * Copyright (c) 2016, The Linux Foundation. All rights reserved.
> > >
> > > I'm surprised you aren't adding a 2024 Qualcomm Innovation Center copyright
> > qpic_common.c file is derived from drivers/mtd/nand/raw/qcom_nandc.c file
> > so I am retaining the Copyright from the drivers/mtd/nand/raw/qcom_nandc.c file
>
> If you have a derived file then you should retain the copyright of the
> original but then also add current copyright for all changes made on top of
> the original file.
Ok, will update in next revision.
>