Re: [PATCH v6 07/11] printk: Constrain hardware-addressed console checks to name position

From: Tony Lindgren
Date: Tue Oct 29 2024 - 04:26:48 EST


On Mon, Oct 28, 2024 at 04:45:48PM +0000, Chris Down wrote:
> Commit 7640f1a44eba ("printk: Add
> match_devname_and_update_preferred_console()") adds support for
> DEVNAME:n:n style console= registration. It determines whether or not
> this is a hardware-addressed console by looking at whether the console=
> string has a colon in it. However, this interferes with loglevel:n and
> potentially other future named options, which also make use of the
> character.
>
> In order to avoid this, only search positions before options.

Looks good to me:

Reviewed-by: Tony Lindgren <tony.lindgren@xxxxxxxxxxxxxxx>