Re: [PATCH] iommu: Restore iommu_flush_iotlb_all()

[Jason Gunthorpe]

On Tue, Oct 29, 2024 at 12:23:02PM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@xxxxxxx>
> 
> This patch restores the iommu_flush_iotlb_all() function.
> Commit
> 
> 	69e5a17511f6 ("iommu: Remove useless flush from iommu_create_device_direct_mappings()")
> 
> claims it removed the last call-site, except it did not. There is still
> at least one caller in
> 
> 	drivers/gpu/drm/msm/msm_iommu.c

Yikes, that iss some scary stuff

> so keep the function around until all call-sites are updated.
> 
> Cc: Jason Gunthorpe <jgg@xxxxxxxx>
> Fixes: 69e5a17511f6 ("iommu: Remove useless flush from iommu_create_device_direct_mappings()")
> Signed-off-by: Joerg Roedel <jroedel@xxxxxxx>
> ---
>  include/linux/iommu.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Strange that 0-day didn't flag this in my trees. We really need to get
0-day running on the iommu list too :\

Jason