Re: [RFC 00/14] AMD: Add Secure AVIC Guest Support
From: Kirill A. Shutemov
Date: Tue Oct 29 2024 - 07:52:16 EST
On Tue, Oct 29, 2024 at 03:54:24PM +0530, Neeraj Upadhyay wrote:
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index aeda74bf15e6..08156ac4ec6c 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -1163,6 +1163,9 @@ void disable_local_APIC(void)
> if (!apic_accessible())
> return;
>
> + if (apic->teardown)
> + apic->teardown();
> +
> apic_soft_disable();
>
> #ifdef CONFIG_X86_32
Hm. I think it will call apic->teardown() for all but the one CPU that
does kexec. I believe we need to disable SAVIC for all CPUs.
Have you tested the case when the target kernel doesn't support SAVIC and
tries to use a new interrupt vector on the boot CPU? I think it will
break.
--
Kiryl Shutsemau / Kirill A. Shutemov