Re: [PATCH v3 3/3] acpi,srat: give memory block size advice based on CFMWS alignment

From: David Hildenbrand
Date: Tue Oct 29 2024 - 08:42:28 EST



static int __init acpi_parse_cfmws(union acpi_subtable_headers *header,
void *arg, const unsigned long table_end)
{
@@ -545,6 +569,15 @@ int __init acpi_numa_init(void)
* Initialize a fake_pxm as the first available PXM to emulate.
*/
+ /* Align memblock size to CFMW regions if possible */
+ acpi_table_parse_cedt(ACPI_CEDT_TYPE_CFMWS, acpi_align_cfmws, NULL);
+
+ /*
+ * Nodes start populating with blocks after this, so probe the max
+ * block size to prevent it from changing in the future.
+ */
+ memory_block_probe_max_size();
+

This looks odd. Why shouldn't we allow someone else to suggest/advise an even smaller "max size" ? I'd drop that.

--
Cheers,

David / dhildenb