Re: [PATCH 2/2] x86/bugs: Clean-up verw mitigations

[Borislav Petkov]

On Tue, Oct 29, 2024 at 07:40:28AM -0700, Daniel Sneddon wrote:
> Sure, I'll split this up as much as possible.

Actually, thinking about this more and looking at David's rework:

https://lore.kernel.org/r/20240912190857.235849-1-david.kaplan@xxxxxxx

his basically is achieving what you're doing - a post-everything routine which
selects the final mitigation strategy once all the mitigation options have
been parsed and evaluated.

So I'm wondering if we should simply take his directly...

He removes that md_clear* function:

https://lore.kernel.org/r/20240912190857.235849-8-david.kaplan@xxxxxxx

in favor of doing the final selection in the ->apply* functions and keeping
each mitigation functions simple.

Yours does this in a single function.

Practically speaking, the end result is the same.

Hmm...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette