Re: [PATCH] platform/x86/amd/hsmp: fix compile-testing without CONFiG_AMD_NB

[Borislav Petkov]

On Tue, Oct 29, 2024 at 02:39:41PM +0200, Ilpo Järvinen wrote:
> I don't like this very wording because what the code very much does is 
> NULL check on node_to_amd_nb() which leads to immediate failure of 
> .probe(). (We don't call other deferences after a NULL check "NULL pointer 
> dereference" either so none is introduced by this patch, IMO.)

I was wondering that too: where does this line

	 sock->root                      = node_to_amd_nb(i)->root;

quoted by gcc come from?

IOW, what is the correct Fixes: tag?

The commit 7d3135d16356 ("platform/x86/amd/hsmp: Create separate ACPI, plat and common drivers

is only in next AFAICT, so I'll drop the Fixes: tag when sending...

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette