Re: [PATCH] perf/arm_pmuv3: fix building on 32-bit

From: Will Deacon
Date: Tue Oct 29 2024 - 11:29:44 EST


On Tue, Oct 29, 2024 at 03:24:10PM +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The write_pmuacr() function is only defined on arm64, so building the
> driver on 32-bit arm now fails:
>
> drivers/perf/arm_pmuv3.c: In function 'armv8pmu_enable_user_access':
> drivers/perf/arm_pmuv3.c:784:17: error: implicit declaration of function 'write_pmuacr'; did you mean 'write_pmcr'? [-Wimplicit-function-declaration]
>
> Add a compile-time check around the newly added code, as it is never
> needed on arm32.
>
> Fixes: 0bbff9ed8165 ("perf/arm_pmuv3: Add PMUv3.9 per counter EL0 access control")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/perf/arm_pmuv3.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)

Cheers, Arnd. Rob already sent a fix for this [1], which I'll push out
shortly.

Will

[1] https://lore.kernel.org/linux-arm-kernel/20241029120602.4061566-2-robh@xxxxxxxxxx/