Re: [PATCH 1/1] media: v4l2-subdev: Drop HAS_EVENTS and event handlers

[Tommaso Merciai]

Hi Sakari,
Thanks for your review.

On Tue, Oct 29, 2024 at 09:16:55PM +0000, Sakari Ailus wrote:
> Hi Tommaso, Laurent,
> 
> On Tue, Oct 29, 2024 at 10:58:49PM +0200, Laurent Pinchart wrote:
> > Hi Tommaso,
> > 
> > Thank you for the patch.
> > 
> > The subject should start with "media: i2c:", not "media: v4l2-subdev:".
> > 
> > On Tue, Oct 29, 2024 at 05:21:05PM +0100, Tommaso Merciai wrote:
> > > v4l2_subdev_init_finalize() already sets the HAS_EVENTS flag if a
> > > control handler is set, and subdev_do_ioctl() uses
> > > v4l2_ctrl_subdev_subscribe_event() and v4l2_event_subdev_unsubscribe()
> > > as defaults if the subdev doesn't have .(un)subscribe.
> > 
> > That will be true once patch "[PATCH v2] media: v4l2-subdev: Refactor
> > events" gets merged. It's good practice to list dependencies, possibly
> > below the --- line (or in a cover letter) if you don't want it to appear
> > in the commit message. I also recommend setting the format.useAutoBase
> > option to automate recording of the base commit in the patch.
> 
> There was some fuzz applying this to the Alvium driver. I've pushed the
> result to the devel branch in my git.linuxtv.org tree.

Sorry, I have some "todo" commits in my tree I will fix that in v2.

Thanks & Regards,
Tommaso

> 
> -- 
> Regards,
> 
> Sakari Ailus