Re: [PATCH v5 04/16] init/main.c: Move EFI runtime service initialization to x86/cpu

[Sohil Mehta]

Would a better title be?

x86/efi: Move runtime service initialization to arch/x86


On 10/28/2024 9:07 AM, Alexander Shishkin wrote:
> The EFI call in start_kernel() is guarded by #ifdef CONFIG_X86. Move
> the thing to the arch_cpu_finalize_init() path on x86 and get rid of
> the #ifdef in start_kernel().
> 
> No functional change intended.
> 
> Signed-off-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
> Suggested-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> ---
>  arch/x86/kernel/cpu/common.c | 7 +++++++
>  init/main.c                  | 5 -----
>  2 files changed, 7 insertions(+), 5 deletions(-)


Other than that,
Reviewed-by: Sohil Mehta <sohil.mehta@xxxxxxxxx>