Re: [RFC PATCH 2/2] net: selpcimac: Add driver for SEL PCIe network adapter

[Robert Joslyn]

>________________________________________
>From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
>Sent: Tuesday, October 29, 2024 10:19 AM
>To: Robert Joslyn; linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx
>Cc: lee@xxxxxxxxxx
>Subject: Re: [RFC PATCH 2/2] net: selpcimac: Add driver for SEL PCIe network adapter
>
>[Caution - External]
>
>Le 28/10/2024 à 23:35, Robert Joslyn a écrit :
>> Add support for SEL FPGA based network adapters. The network device is
>> implemented as an FPGA IP core and enumerated by the selpvmf driver.
>> This is used on multiple devices, including:
>>   - SEL-3350 mainboard
>>   - SEL-3390E4 card
>>   - SEL-3390T card
>>
>> Signed-off-by: Robert Joslyn <robert_joslyn@xxxxxxxxxx>
>> ---
>
>Hi,
>
>a few nitpicks below, should it help.
>
...
>> +
>> +     WARN_ON_ONCE((ring->dma % SEL_DATA_ALIGN) != 0);
>> +
>> +     memset(ring->desc, 0, ring->size);
>
>If I recollect correctly, dma_alloc_coherent() returns some zeroed memory.

You're right, I walked through that code and it does a memset to zero internally.

>
>CJ
>

Thanks for taking a look, I'll work these suggestions into the next patch set.

Robert