Re: [RFC bpf-next fanotify 2/5] samples/fanotify: Add a sample fanotify fastpath handler

From: Song Liu
Date: Tue Oct 29 2024 - 22:35:31 EST




> On Oct 29, 2024, at 7:07 PM, Song Liu <songliubraving@xxxxxxxx> wrote:
>
>
>
>> On Oct 29, 2024, at 5:11 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>>
>> On Tue, Oct 29, 2024 at 04:12:41PM -0700, Song Liu wrote:
>>> + if (strstr(file_name->name, item->prefix) == (char *)file_name->name)
>>
>> Huh? "Find the first substring (if any) equal to item->prefix and
>> then check if that happens to be in the very beginning"???
>
> Replaced it with strcmp locally, assuming strncmp is not necessary.

Oops, we do need strncmp and more coffee..