Re: [PATCH v5 06/13] iommu: Add iommu_copy_struct_from_full_user_array helper

[Nicolin Chen]

On Tue, Oct 29, 2024 at 08:24:52AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <nicolinc@xxxxxxxxxx>
> > Sent: Saturday, October 26, 2024 7:51 AM
> >
> > From: Jason Gunthorpe <jgg@xxxxxxxxxx>
> >
> > The iommu_copy_struct_from_user_array helper can be used to copy a
> > single
> > entry from a user array which might not be efficient if the array is big.
> >
> > Add a new iommu_copy_struct_from_full_user_array to copy the entire user
> > array at once. Update the existing iommu_copy_struct_from_user_array
> > kdoc
> > accordingly.
> 
> what about:
> 
> iommu_copy_struct_from_user_array_single()
> iommu_copy_struct_from_user_array_full()

I am okay with that, yet might prefer that in a separate patch? As
I am trying to reduce the number of changes in the series since we
are likely merging three series at once :)

Thanks
Nicolin

> > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
> > Signed-off-by: Nicolin Chen <nicolinc@xxxxxxxxxx>
> 
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>