Re: [PATCH V2 3/3] interconnect: qcom: Add EPSS L3 support on SA8775P

From: Raviteja Laggyshetty
Date: Wed Oct 30 2024 - 02:55:58 EST




On 10/26/2024 9:05 PM, Dmitry Baryshkov wrote:
> On Sat, Oct 26, 2024 at 12:30:58PM +0000, Raviteja Laggyshetty wrote:
>> Add Epoch Subsystem (EPSS) L3 interconnect provider support on
>> SA8775P SoCs.
>
> Please describe the reason for your changes. In its current form the
> patch doesn't provide enough details.
>
I will update the commit text in next revision of patch.
> Moreover I don't think it's a correct solution. Using a single ID space
> for an interconnects doesn't really scale. In the longer term we should
> follow CCF approach and switch to using the icc_node pointers when they
> are known.
>
That's correct, We will take it as separate patch series.
>>
>> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@xxxxxxxxxxx>
>> ---
>> drivers/interconnect/qcom/osm-l3.c | 86 ++++++++++++++++++++++--------
>> 1 file changed, 64 insertions(+), 22 deletions(-)
>>
>