Re: [tip:timers/vdso 11/13] include/vdso/page.h:15:39: error: 'CONFIG_PAGE_SHIFT' undeclared here (not in a function); did you mean 'CONFIG_LOG_BUF_SHIFT'?

[Geert Uytterhoeven]

Hi Arnd,

On Tue, Oct 29, 2024 at 11:05 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Tue, Oct 29, 2024, at 21:18, Thomas Gleixner wrote:
> > On Tue, Oct 29 2024 at 06:38, kernel test robot wrote:
> > That's actually not the culprit. The problem exists in mainline too. The
> > actual root cause is:
> >
> >   5394f1e9b687 ("arch: define CONFIG_PAGE_SIZE_*KB on all architectures")
> >
> > The config has no CONFIG_PAGE_SHIFT because nothing selects a page size. The
> > the original code had:
> >
> > if defined(CONFIG_SUN3) || defined(CONFIG_COLDFIRE)
> > #define PAGE_SHIFT     13
> > #else
> > #define PAGE_SHIFT     12
> > #endif
> >
> > But the Kconfig magic changes made this depend on various other things.
> >
> > The patch below cures it, but it needs an eyeball from Geert.
>
> I have previously suggested a similar but more extensive patch
> to address the problem:
>
> https://lore.kernel.org/all/CAMuHMdVC-FUSA5C9aNrvP3=RaRWrchhUEC5UYcSGMz_ep1PEhg@xxxxxxxxxxxxxx/
>
> I can rebase that one if Geert still wants it. I think I sent

I am still interested ;-)

> an updated version somewhere but can't find it now.

AFAIK you haven't, so there are still outstanding review comments on
the last version you sent...
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds