Re: [PATCH v3 2/2] arm64: dts: qcom: qcs615-ride: Enable PMIC peripherals

[Tingguo Cheng]

On 10/28/2024 5:41 PM, Dmitry Baryshkov wrote:
> On Mon, 28 Oct 2024 at 10:40, Tingguo Cheng <quic_tingguoc@xxxxxxxxxxx> wrote:
> > On 10/28/2024 4:23 PM, Dmitry Baryshkov wrote:
> > > On Mon, Oct 28, 2024 at 04:03:25PM +0800, Tingguo Cheng wrote:
> > > > Enable PMIC and PMIC peripherals for qcs615-ride board.
> > > >
> > > > Signed-off-by: Tingguo Cheng <quic_tingguoc@xxxxxxxxxxx>
> > > > ---
> > > >    arch/arm64/boot/dts/qcom/qcs615-ride.dts | 15 +++++++++++++++
> > > >    1 file changed, 15 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > > > index ee6cab3924a6d71f29934a8debba3a832882abdd..37358f080827bbe4484c14c5f159e813810c2119 100644
> > > > --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > > > +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > > > @@ -6,6 +6,7 @@
> > > >
> > > >    #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> > > >    #include "qcs615.dtsi"
> > > > +#include "pm8150.dtsi"
> > > >    / {
> > > >       model = "Qualcomm Technologies, Inc. QCS615 Ride";
> > > >       compatible = "qcom,qcs615-ride", "qcom,qcs615";
> > > > @@ -210,6 +211,20 @@ &rpmhcc {
> > > >       clocks = <&xo_board_clk>;
> > > >    };
> > > >
> > > > +&pon {
> > > > +    /delete-property/ mode-bootloader;
> > > > +    /delete-property/ mode-recovery;
> > >
> > > Why?
> > Because boot modes will be supported on PSCI module from another patch,
> > reboot-modes are required to remove from PMIC side.
>
> => commit message, please.
okay, will upload v4 with other comments fixing together.
> > > > +};
> > > > +
> > > > +&pon_pwrkey {
> > > > +    status = "okay";
> > > > +};
> > > > +
> > > > +&pon_resin {
> > > > +    linux,code = <KEY_VOLUMEDOWN>;
> > > > +    status = "okay";
> > > > +};
> > > > +
> > > >    &uart0 {
> > > >       status = "okay";
> > > >    };
> > > >
> > > > --
> > > > 2.34.1
> >
> > --
> > Thank you & BRs
> > Tingguo

--
Thank you & BRs
Tingguo