Re: [PATCH 4/4] arm64: dts: agilex5: initial support for Arrow AXE5-Eagle

From: Andrew Lunn
Date: Wed Oct 30 2024 - 09:41:33 EST


> +&gmac2 {
> + status = "okay";
> + phy-mode = "rgmii-id";
> + phy-handle = <&emac2_phy0>;
> +
> + max-frame-size = <9000>;
> +
> + mdio0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "snps,dwmac-mdio";
> + emac2_phy0: ethernet-phy@1 {
> + reg = <0x1>;
> + adi,rx-internal-delay-ps = <2000>;
> + adi,tx-internal-delay-ps = <2000>;

You have rgmii-id and 2000ps delay? Are these two lines actually
required?

Andrew