Re: [PATCH v2 1/2] hwmon: (pwm-fan) add option to leave fan on shutdown

[Guenter Roeck]

On 10/30/24 07:55, Akinobu Mita wrote:
> 2024年10月29日(火) 11:35 Billy Tsai <billy_tsai@xxxxxxxxxxxxxx>:
> > > This adds an optional property "retain-state-shutdown" as requested by
> > > Billy Tsai.
> >
> > > Billy said:
> > >   "Our platform is BMC that will use a PWM-FAN driver to control the fan
> > >   on the managed host. In our case, we do not want to stop the fan when
> > >   the BMC is reboot, which may cause the temperature of the managed host
> > >   not to be lowered."
> >
> > I confirmed that it works properly.
> >
> > Reviewed-by: Billy Tsai <billy_tsai@xxxxxxxxxxxxxx>
> > Tested-by: Billy Tsai <billy_tsai@xxxxxxxxxxxxxx>
>
> Thank you very much for testing.
> However, I plan to change this option to device attribute
> (/sys/class/hwmon/hwmonX/retain-state-shutdown) instead of the device tree.


No, I won't acccept that.

Guenter