Re: [PATCH 10/11] clk: qcom: videocc-qcs615: Add QCS615 video clock controller driver

[Taniya Das]

On 10/19/2024 2:01 AM, Dmitry Baryshkov wrote:
> > +static const struct pll_vco video_cc_pll0_vco[] = {
> > +	{ 500000000, 1000000000, 2 },
> > +};
> > +
> > +/* 600MHz configuration */
> > +static struct alpha_pll_config video_pll0_config = {
> > +	.l = 0x1F,
> lowercase the hex, please. LGTM otherwise.

Will fix in the next patch.

> > +	.alpha_hi = 0x40,
> > +	.alpha = 0x00,
> > +	.alpha_en_mask = BIT(24),

--
Thanks & Regards,
Taniya Das.